Skip to main content
Added Rietveld example
Source Link
Jan Fabry
  • 30.5k
  • 17
  • 23

As much as I want code reviews, I don't think this site is the best format for it. Code reviews to me are either focused on some specific lines of code ("You use $i here but $j there - by intent or mistake?") or on a larger concept ("Why did you choose to solve it this or that way?"). They require discussion, back-and-forths, while the comment system here is intentionally limited.

I know all of us want to do and request code reviews, and we must do something with all that positive energy, but I suggest we try to find (or create) a dedicated system to handle this, since it is a completely different beast than the "best answer floats to the top" style of Stack Exchange.

Edit: I searched around for code review software, and started playing with Rietveld, an open source project created by Guido van Rossum (creator of Python) at Google. One can easily host it on the Google App Engine, and you can play with a live version there. I have uploaded a file to see how this would work, maybe you all should take a look an see if this is a good starting point?

As much as I want code reviews, I don't think this site is the best format for it. Code reviews to me are either focused on some specific lines of code ("You use $i here but $j there - by intent or mistake?") or on a larger concept ("Why did you choose to solve it this or that way?"). They require discussion, back-and-forths, while the comment system here is intentionally limited.

I know all of us want to do and request code reviews, and we must do something with all that positive energy, but I suggest we try to find (or create) a dedicated system to handle this, since it is a completely different beast than the "best answer floats to the top" style of Stack Exchange.

As much as I want code reviews, I don't think this site is the best format for it. Code reviews to me are either focused on some specific lines of code ("You use $i here but $j there - by intent or mistake?") or on a larger concept ("Why did you choose to solve it this or that way?"). They require discussion, back-and-forths, while the comment system here is intentionally limited.

I know all of us want to do and request code reviews, and we must do something with all that positive energy, but I suggest we try to find (or create) a dedicated system to handle this, since it is a completely different beast than the "best answer floats to the top" style of Stack Exchange.

Edit: I searched around for code review software, and started playing with Rietveld, an open source project created by Guido van Rossum (creator of Python) at Google. One can easily host it on the Google App Engine, and you can play with a live version there. I have uploaded a file to see how this would work, maybe you all should take a look an see if this is a good starting point?

Source Link
Jan Fabry
  • 30.5k
  • 17
  • 23

As much as I want code reviews, I don't think this site is the best format for it. Code reviews to me are either focused on some specific lines of code ("You use $i here but $j there - by intent or mistake?") or on a larger concept ("Why did you choose to solve it this or that way?"). They require discussion, back-and-forths, while the comment system here is intentionally limited.

I know all of us want to do and request code reviews, and we must do something with all that positive energy, but I suggest we try to find (or create) a dedicated system to handle this, since it is a completely different beast than the "best answer floats to the top" style of Stack Exchange.